-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602) #18708
Conversation
Hey @bgawrych , Thanks for submitting the PR
CI supported jobs: [windows-cpu, unix-gpu, windows-gpu, edge, centos-gpu, miscellaneous, website, sanity, unix-cpu, centos-cpu, clang] Note: |
326e0cd
to
c5915fe
Compare
@mxnet-bot run ci [edge, unix-gpu] |
Jenkins CI successfully triggered : [edge, unix-gpu] |
@mxnet-bot run ci [edge, unix-gpu] |
Jenkins CI successfully triggered : [edge, unix-gpu] |
@TaoLv @PatricZhao Can you take a look? |
@bgawrych I'm rebasing your branch to the latest of v1.x. |
@mxnet-bot run ci [website] |
Jenkins CI successfully triggered : [website] |
Not sure what's the merge policy of v1.x. Github keeps saying this branch is out of date w ith the base branch so we cannot merge it. |
@mxnet-bot run ci [unix-gpu] |
Jenkins CI successfully triggered : [unix-gpu] |
@mxnet-bot run ci [unix-gpu] |
Jenkins CI successfully triggered : [unix-gpu] |
Co-authored-by: Hao Jin <hjjn.amzn@gmail.com>
* Fix failing empty array (log_)softmax * Modify test for npx (log_)softmax
e766ecc
to
55cb012
Compare
@mxnet-bot run ci [all] |
Jenkins CI successfully triggered : [edge, centos-gpu, sanity, unix-gpu, clang, centos-cpu, unix-cpu, miscellaneous, website, windows-gpu, windows-cpu] |
@TaoLv @PatricZhao I think that the problem with out of date branch is solved |
@bgawrych Thanks. Now it's merged. |
Description
Backport of two changes:
Third commit "Fix softmax, logsoftmax backward failed on empty ndarray (#18710)" is not backported
directly from master branch because fix was covered by other PR improving unittests (#18694).
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.