Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Improve test seeding and robustness in test_numpy_interoperablity.py #18762

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

DickJC123
Copy link
Contributor

Description

I recently ran into a CI failure in test_numpy_interoperability.py::test_np_array_function_protocol: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Fwindows-cpu/detail/PR-18694/14/pipeline. I was not able to use the reported seed for the failure to reproduce it. I have investigated why and am supplying this PR as a fix- now reported seeds can be used to repro failures. I was then able to use the new facility to troubleshoot which tests needed loosened tolerances for increased test robustness, and have supplied that as well- the failure rate I estimate now is around 1:10000.

As a review, the robustness of a test should be able to be explored with:

MXNET_TEST_COUNT=10000 pytest --verbose -s --log-cli-level=DEBUG <my_test>
<see a failure, note failure seed NNN>
MXNET_TEST_SEED=NNN pytest --verbose -s <my_test>

The issue with test_numpy_interoperability.py was that it was creating a test workload at file import time using unseeded random values. The fix makes the workload be regenerated for each test at test runtime in a manner that will depend on the seed of the test.

The two tests that required loosened tolerances were linalg.tensorinv and linalg.solve. At the setting as I left them, I saw 1 failure in 10K trials. Rather than loosening the tolerances further, I will leave it to the code owners to diagnose the situation and propose a fix if they see fit to. The tolerances could be loosened further, but other approaches could involve changing the scale or other properties of the input data. The remaining failure can (after the PR is merged) be repro'd with:

MXNET_TEST_SEED=801992040 pytest --verbose -s tests/python/unittest/test_numpy_interoperability.py::test_np_array_function_protocol

A curious property of the remaining failure is that so many of the values are consistently smaller than the golden copy by 1.9%:

Dispatch test: linalg.tensorinv

*** Maximum errors for vector of size 3600:  rtol=0.01, atol=0.005

  1: Error 1.934343  Location of error: (1, 1, 0, 10, 4), a=128.42663574, b=130.96971130
  2: Error 1.933410  Location of error: (2, 0, 2, 6, 0), a=80.68855286, b=82.28920746
  3: Error 1.933032  Location of error: (2, 0, 2, 8, 3), a=61.98265076, b=63.21426773
  4: Error 1.931998  Location of error: (1, 2, 2, 4, 4), a=-151.11050415, b=-154.09732056
  5: Error 1.931560  Location of error: (1, 1, 0, 4, 4), a=-97.56709290, b=-99.49862671
  6: Error 1.931458  Location of error: (0, 0, 2, 10, 4), a=343.97329712, b=350.75769043
  7: Error 1.931435  Location of error: (1, 2, 2, 10, 4), a=199.16923523, b=203.10166931
  8: Error 1.931303  Location of error: (1, 2, 2, 9, 0), a=116.00872803, b=118.30317688
  9: Error 1.931238  Location of error: (1, 2, 0, 4, 2), a=1058.37841797, b=1079.23059082
 10: Error 1.931191  Location of error: (1, 1, 1, 10, 4), a=702.60571289, b=716.45141602
[WARNING] Setting test np/mx/python random seeds, use MXNET_TEST_SEED=801992040 to reproduce.

[This PR may have additional fixes to other tests if I can't get a clean CI]

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @DickJC123 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, windows-cpu, unix-gpu, centos-cpu, unix-cpu, sanity, edge, windows-gpu, miscellaneous, clang, website]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@DickJC123
Copy link
Contributor Author

Tagging @reminisce and @szha (who introduced/modified test_np_array_function_protocol) for comment.

@ptrendx ptrendx merged commit 6bb3d72 into apache:master Jul 20, 2020
DickJC123 added a commit to DickJC123/mxnet that referenced this pull request Sep 15, 2020
szha pushed a commit that referenced this pull request Sep 17, 2020
…so test seeding (#18762). (#19148)

* Add sm arch 80 to Makefile

* Unittest tolerance handling improvements (#18694)

* Add sm arch 80 to Makefile

* Add TF32 to cuBLAS GEMMs

Signed-off-by: Serge Panev <spanev@nvidia.com>

* Add CUDA version guards

Signed-off-by: Serge Panev <spanev@nvidia.com>

* Remove useless TF32 for double and old CUDA version

Signed-off-by: Serge Panev <spanev@nvidia.com>

* Factorize VERSION_ADJUSTED_TF32_MATH

Signed-off-by: Serge Panev <spanev@nvidia.com>

* Add TF32 considerations to test_util.py:check_consistency()

* Bypass test_gluon_gpu.py:test_large_models if gmem >32GB

* Default tols in assert_almost_equal() now a function of dtype and ctx

* Expand types listed by default_tols()

* Fix pylint

* All with_seed() tests to waitall in teardown

* Elevate MXNET_TEST_SEED logging to WARNING

* Revert test_gluon_gpu.py:test_rnn_layer to default tols

* Fix test_gluon_model_zoo_gpu.py::test_inference and test_operator_gpy.py::test_np_linalg_{solve,tensorinv}

* test_numpy_interoperability.py to not fix seed for rest of CI

* Further fix to test_np_linalg_tensorinv

* Fix test_gluon_data.py:test_dataloader_context when run on 1-GPU system.

* Fix test_operator_gpu.py::test_embedding_with_type

* Fix test_operator_gpu.py::{test_*convolution_large_c,test_np_linalg_tensorsolve}

* Remove unneeded print() from test_numpy_interoperability.py

* Unify tol handling of check_consistency() and assert_almost_equal().  Test tweeks.

* Add tol handling of assert_almost_equal() with number args

* Add tol handling of bool comparisons

* Fix test_numpy_op.py::test_np_random_rayleigh

* Fix test_operator_gpu.py::test_batchnorm_with_type

* Fix test_gluon.py::test_sync_batchnorm in cpu selftest

* Improve unittest failure reporting

* Add to robustness of test_operator_gpu.py::test_embedding_with_type

* Check_consistency() to use equal backward gradients for increased test robustness

* Fix test_operator_gpu.py::test_{fully_connected,gemm}.  Add default_numeric_eps().

* test_utils.py fix for numeric gradient calc

* Reinstate rtol=1e-2 for test_operator.py::test_order

* Remove auto-cast of check_consistency() input data to least precise dtype (not needed)

* Fix test_operator.py::test_{reciprocol,cbrt,rcbrt}_op

* Expand default float64 numeric_eps for test_operator_gpu.py::test_sofmin

* Fix segfault-on-error of @Retry decorator. Add test isolation.

* assert_almost_equal() to handle a,b scalars

* Fix test_operator_gpu.py::test_gluon_{mvn,mvn_v1} race

* Fix test_operator_gpu.py::test_flatten_slice_after_conv via scale

* Remove test_utils.py:almost_equal_ignore_nan()

* Fix sample vs. pop variance issue with test_numpy_op.py::test_npx_batch_norm

* Expose test_utils.py:effective_dtype() and use to fix test_operator_gpu.py::test_np_linalg_svd

* Fix true_divide int_array / int_scalar -> float_array to honor np_default_dtype

* Try test_elemwise_binary_ops serial to avoid pytest worker crash

* Fix (log_)softmax backward on empty ndarray

* Temporarily log all CI seeds to troubleshoot seed non-determinism

* Revert "Temporarily log all CI seeds to troubleshoot seed non-determinism"

This reverts commit f60eff2.

* Temp log all CI seeds to troubleshoot unwanted seed determinism

* Revert "Add sm arch 80 to Makefile"

This reverts commit f9306ce.

* Same fix of sample vs. pop variance issue, now with test_operator_gpu.py::test_batchnorm

* Revert "Temp log all CI seeds to troubleshoot unwanted seed determinism"

This reverts commit ff328ef.

* Marking test_sparse_dot_grad with garbage_expected after teardown error

* Fix flakiness of test_gluon_probability{_v1,_v2}.py::test_gluon_kl{_v1,}

* Temp skip of test_aggregate_duplication on gpu

* Add seeding to test_{numpy,}_contrib_gluon_data_vision.py.  Make created files unique.

* Add ndarray module isolation to help debug test_bbox_augmenters worker crash

* Marking test_sparse_square_sum serial after pytest worker crash

* Fix flakiness of test_gluon_probability{_v1,_v2}.py::test_half_cauchy{_v1,}

Co-authored-by: Serge Panev <spanev@nvidia.com>
Co-authored-by: Bart Gawrych <gawrych.bartlomiej@intel.com>

* Fix test_gluon_data.py:test_dataloader_context when run on 1-GPU system.

* Remove pytest decorators introduced in error

* Fix test_forward.py:test_consistency

* Fix test_numpy_op.py tests

* Improve test seeding in test_numpy_interoperablity.py (#18762)

* Fix test_numpy_op.py:test_np_random_{beta,chisquare}

* Reduce problem sizes with test_optimizer.py:test_multilamb

* Skip test_gluon_gpu.py:test_fused_{lstm,gpu}_layer, fix test_rnn_cells, for fp16 contexts

* Trigger CI

Co-authored-by: Serge Panev <spanev@nvidia.com>
Co-authored-by: Bart Gawrych <gawrych.bartlomiej@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants