Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

clean up C API #18969

Merged
merged 2 commits into from
Aug 23, 2020
Merged

clean up C API #18969

merged 2 commits into from
Aug 23, 2020

Conversation

szha
Copy link
Member

@szha szha commented Aug 20, 2020

Description

clean up C API following #17676

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • clean up C API following

Changes

  • removed torch module
  • MXAggregateProfileStatsPrintEx renamed to MXAggregateProfileStatsPrint
  • MXNDArrayCreateEx64 renamed to MXNDArrayCreate64
  • MXNDArrayCreateEx renamed to MXNDArrayCreate
  • MXNDArrayCreateFromSharedMemEx renamed to MXNDArrayCreateFromSharedMem
  • MXNDArrayGetShapeEx renamed to MXNDArrayGetShape
  • MXNDArrayGetShapeEx64 renamed to MXNDArrayGetShape64
  • MXNDArrayFromDLPackEx renamed to MXNDArrayFromDLPack
  • MXFuncInvokeEx renamed to MXFuncInvoke
  • MXImperativeInvokeEx renamed to MXImperativeInvoke
  • MXCreateCachedOpEX renamed to MXCreateCachedOp
  • MXCreateCachedOpEx removed
  • MXInvokeCachedOpEx renamed to MXInvokeCachedOp
  • MXSymbolInferShapeEx renamed to MXSymbolInferShape
  • MXSymbolInferShapeEx64 renamed to MXSymbolInferShape64
  • MXSymbolInferShapePartialEx renamed to MXSymbolInferShapePartial
  • MXSymbolInferShapePartialEx64 renamed to MXSymbolInferShapePartial64
  • All MXExecutor* C API was removed, in favor of cached op

@mxnet-bot
Copy link

Hey @szha , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, clang, unix-gpu, unix-cpu, sanity, windows-cpu, windows-gpu, centos-gpu, centos-cpu, miscellaneous, edge]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@szha szha force-pushed the clean_legacy branch 4 times, most recently from 01d0baa to a2c4656 Compare August 21, 2020 18:17
@szha szha force-pushed the clean_legacy branch 4 times, most recently from b937483 to e6a8161 Compare August 22, 2020 23:04
@szha szha merged commit 0de7484 into apache:master Aug 23, 2020
@szha szha deleted the clean_legacy branch August 23, 2020 22:24
ys2843 pushed a commit to ys2843/incubator-mxnet that referenced this pull request Aug 24, 2020
* deprecated ops

* clean up C API
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants