Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Submodule] Upgrade to oneDNN v1.6.3 #19153

Merged
merged 6 commits into from
Sep 16, 2020
Merged

Conversation

TaoLv
Copy link
Member

@TaoLv TaoLv commented Sep 15, 2020

Description

I cannot reopen the original PR #18801, hence a new one.

The compilation issue with GCC 7 should be fixed in the v1.6.3 release per the release note:

https://github.com/oneapi-src/oneDNN/releases/tag/v1.6.3

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @TaoLv , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [sanity, clang, centos-cpu, unix-cpu, unix-gpu, miscellaneous, centos-gpu, windows-gpu, edge, windows-cpu, website]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@TaoLv
Copy link
Member Author

TaoLv commented Sep 16, 2020

@pengzhao-intel @anko-intel @leezu Please take a look. Thanks!

Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and merging now.

@pengzhao-intel pengzhao-intel merged commit ec62fcf into apache:master Sep 16, 2020
anko-intel pushed a commit to anko-intel/incubator-mxnet that referenced this pull request Sep 16, 2020
* upgrade to oneDNN v1.6 release branch

* oneDNN v1.6

* fix cpp test

* build oneDNN with c++11

* Revert "build oneDNN with c++11"

This reverts commit 5365d83.

* oneDNN v1.6.3
@anko-intel
Copy link
Contributor

I put it to branch v1.x also: #19161

@TaoLv
Copy link
Member Author

TaoLv commented Sep 17, 2020

I put it to branch v1.x also: #19161

Thank you @anko-intel !

anko-intel pushed a commit to anko-intel/incubator-mxnet that referenced this pull request Sep 17, 2020
* upgrade to oneDNN v1.6 release branch

* oneDNN v1.6

* fix cpp test

* build oneDNN with c++11

* Revert "build oneDNN with c++11"

This reverts commit 5365d83.

* oneDNN v1.6.3
pengzhao-intel pushed a commit that referenced this pull request Sep 18, 2020
* upgrade to oneDNN v1.6 release branch

* oneDNN v1.6

* fix cpp test

* build oneDNN with c++11

* Revert "build oneDNN with c++11"

This reverts commit 5365d83.

* oneDNN v1.6.3

Co-authored-by: Tao Lv <tao.a.lv@intel.com>
leezu added a commit that referenced this pull request Sep 18, 2020
chinakook pushed a commit to chinakook/mxnet that referenced this pull request Nov 17, 2020
* upgrade to oneDNN v1.6 release branch

* oneDNN v1.6

* fix cpp test

* build oneDNN with c++11

* Revert "build oneDNN with c++11"

This reverts commit 5365d83.

* oneDNN v1.6.3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants