-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[v1.8.x] Automate website artifacts uploading #19244
[v1.8.x] Automate website artifacts uploading #19244
Conversation
Hey @waytrue17 , Thanks for submitting the PR
CI supported jobs: [windows-cpu, clang, sanity, unix-cpu, centos-gpu, edge, centos-cpu, miscellaneous, unix-gpu, website, windows-gpu] Note: |
After this PR gets merged, modify Step 3.2.1 Point 5 in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The PR changes are being tested by this Jenkins pipeline: http://jenkins.mxnet-ci-dev.amazon-ml.com/job/docs/job/sethman-website-artifacts/ |
Hi @ys2843 Could you please review this PR? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just one question:
53260f9
to
198e691
Compare
@mxnet-bot run ci [unix-cpu] |
Jenkins CI successfully triggered : [unix-cpu] |
@marcoabreu can you please review again now that your feedback has been addressed? |
@marcoabreu - Looks like your review comments are addressed. Can you take a look at this and approve / have other feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merging this as it helps automating an important part of website building and all the requested changes by @marcoabreu are addressed. |
@waytrue17 / @mseth10 / @ys2843 => Should this be backported to 1.X branch please? |
Yes, this needs to be backported to 1.x and master. @waytrue17 can you create those PRs? |
Sure, I'll backport it to 1.x and master |
@waytrue17 It doesn't need to be port to master, only to branches that will be built as static artifact. |
Hey @ys2843 , I thought we will need it for any release going forward, be it 1.9 or 2.0. How do we plan to build static artifacts for 2.0 once that branch is cut? |
All versions of MXNet website artifacts are compressed into a zip file and stored in a private S3 bucket, with the following file structure:
For new MXNet versions released, we need to add the new website artifacts into the above zip file and upload it to the S3 bucket. Currently we have a pipeline that generates version specific artifacts, but it's still a manual process to upload them to s3 in the expected format shown above.
This PR aims to automate the website artifact uploading process.
We introduced pipeline
Jenkinsfile_website_upload
to build the new version website artifacts, prepare all versions of website artifacts into the expected format, and upload them to the target S3 bucket. This pipeline utilizes Jenkins environment variableFOLDER_NAME
to specify the name of the new artifacts to be added.