Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix for optimize_for multiple subgraph properties issue #19263

Merged
merged 2 commits into from
Oct 2, 2020
Merged

Fix for optimize_for multiple subgraph properties issue #19263

merged 2 commits into from
Oct 2, 2020

Conversation

samskalicky
Copy link
Contributor

Description

Fixes #19256. Regenerates Graph for each subgraph property and saves partitioned Graph in Symbol.

@mxnet-bot
Copy link

Hey @samskalicky , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, sanity, edge, website, unix-gpu, miscellaneous, clang, windows-cpu, centos-cpu, windows-gpu, unix-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

bgawrych
bgawrych approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@bgawrych bgawrych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - multiple properties in backend aren't problem now

Kh4L
Kh4L approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@Kh4L Kh4L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mseth10
mseth10 approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@mseth10 mseth10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @samskalicky for the clean fix.

@samskalicky samskalicky added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Oct 2, 2020
@samskalicky samskalicky merged commit 7d3e027 into apache:master Oct 2, 2020
bgawrych pushed a commit to bgawrych/incubator-mxnet that referenced this pull request Apr 8, 2021
@samskalicky @bgawrych
Fix for optimize_for multiple subgraph properties issue (apache#19263)
346528e 
* initial commit

* fixed whitespace

Co-authored-by: Ubuntu <ubuntu@ip-172-31-6-220.us-west-2.compute.internal>
@bgawrych bgawrych mentioned this pull request Apr 8, 2021
Merged
bgawrych pushed a commit to bgawrych/incubator-mxnet that referenced this pull request Apr 8, 2021
@samskalicky @bgawrych
Fix for optimize_for multiple subgraph properties issue (apache#19263)
49ec047 
* initial commit

* fixed whitespace

Co-authored-by: Ubuntu <ubuntu@ip-172-31-6-220.us-west-2.compute.internal>
szha pushed a commit that referenced this pull request Apr 12, 2021
@bgawrych @samskalicky
Fix for optimize_for multiple subgraph properties issue (#19263) (#20142
dd3a6f8 
)

* initial commit

* fixed whitespace

Co-authored-by: Ubuntu <ubuntu@ip-172-31-6-220.us-west-2.compute.internal>

Co-authored-by: Sam Skalicky <samskalicky@gmail.com>
Co-authored-by: Ubuntu <ubuntu@ip-172-31-6-220.us-west-2.compute.internal>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bgawrych bgawrych bgawrych approved these changes

@mseth10 mseth10 mseth10 approved these changes

@Kh4L Kh4L Kh4L approved these changes

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple subgraph properties with single backend issue with optimize_for
5 participants
@samskalicky @mxnet-bot @Kh4L @mseth10 @bgawrych