Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[1.x] Fixed setting attributes in reviewSubgraph #19274

Merged
merged 7 commits into from
Oct 6, 2020

Conversation

samskalicky
Copy link
Contributor

@samskalicky samskalicky commented Oct 2, 2020

Description

Fixed bugs introduced in #18779:

  • prevents setting attributes on subgraph ops
  • getting the subgraph string from a const Graph object
  • setting tensors on param nodes, maps from subgraph input names to top level graph names
  • added support for escaping quotes \" when parsing strings in json
  • adding new nodes in graph pass
  • aligned string allocation to match free (was new changed to malloc)

@mxnet-bot
Copy link

Hey @samskalicky , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, windows-cpu, edge, windows-gpu, unix-cpu, unix-gpu, sanity, website, centos-cpu, centos-gpu, clang]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@samskalicky samskalicky changed the title Fixed setting attributes in reviewSubgraph [1.x] Fixed setting attributes in reviewSubgraph Oct 2, 2020
@sandeep-krishnamurthy
Copy link
Contributor

@mseth10 @waytrue17 can you please help review. Thanks.

Copy link
Contributor

@access2rohit access2rohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samskalicky samskalicky merged commit 3b69c60 into apache:v1.x Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants