Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

More extensions fixes #19393

Merged
merged 7 commits into from
Oct 23, 2020
Merged

More extensions fixes #19393

merged 7 commits into from
Oct 23, 2020

Conversation

samskalicky
Copy link
Contributor

@samskalicky samskalicky commented Oct 20, 2020 •
edited
Loading

Description

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @samskalicky , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, clang, centos-gpu, centos-cpu, windows-cpu, windows-gpu, edge, unix-cpu, miscellaneous, sanity, unix-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-work-in-progress PR is still work in progress label Oct 20, 2020
@samskalicky samskalicky changed the title [WIP] subgraph op fixes [WIP] More extensions fixes Oct 20, 2020
samskalicky added a commit to samskalicky/incubator-mxnet that referenced this pull request Oct 21, 2020
@samskalicky
backport apache#19393 to v1.x
9ca57b4
@samskalicky samskalicky mentioned this pull request Oct 21, 2020
Closed
6 tasks
samskalicky added a commit to samskalicky/incubator-mxnet that referenced this pull request Oct 21, 2020
@samskalicky
backport apache#19393 to v1.x
779e932
@samskalicky samskalicky mentioned this pull request Oct 21, 2020
Merged
6 tasks
samskalicky added a commit to samskalicky/incubator-mxnet that referenced this pull request Oct 21, 2020
@samskalicky
backport apache#19393 to v1.x
0e2d338
@samskalicky samskalicky mentioned this pull request Oct 21, 2020
Merged
6 tasks
@samskalicky samskalicky mentioned this pull request Oct 21, 2020
Merged
5 tasks
mseth10
mseth10 approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@mseth10 mseth10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mseth10 mseth10 changed the title [WIP] More extensions fixes More extensions fixes Oct 23, 2020
@mseth10 mseth10 added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-work-in-progress PR is still work in progress labels Oct 23, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-merge Review and CI is complete. Ready to Merge labels Oct 23, 2020
mseth10 pushed a commit that referenced this pull request Oct 23, 2020
@samskalicky
backport #19393 to v1.x (#19396)
fdc6022 
* backport #19393 to v1.x

* other commits

* namespace fix

* added copying lib_api.cc into pip wheel for building extensions

* fixed setup.py
mseth10 pushed a commit that referenced this pull request Oct 23, 2020
@samskalicky
backport #19393 to v1.8.x (#19398)
aba3aa3 
* backport #19393 to v1.x

* other commits

* namespace fix

* added copying lib_api.cc into pip wheel for building extensions

* fixed setup.py
@lanking520 lanking520 added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 23, 2020
@mseth10 mseth10 merged commit 8e5a16c into apache:master Oct 23, 2020
josephevans pushed a commit to josephevans/mxnet that referenced this pull request Dec 8, 2020
@samskalicky
backport apache#19393 to v1.x (apache#19396)
6138904 
* backport apache#19393 to v1.x

* other commits

* namespace fix

* added copying lib_api.cc into pip wheel for building extensions

* fixed setup.py
@samskalicky samskalicky mentioned this pull request Feb 5, 2021
Merged
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@awsabinasm awsabinasm awsabinasm approved these changes

@mseth10 mseth10 mseth10 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

@eric-haibin-lin eric-haibin-lin Awaiting requested review from eric-haibin-lin eric-haibin-lin is a code owner

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samskalicky @mxnet-bot @mseth10 @awsabinasm @lanking520