This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[FEATURE] Add option to build with shared c runtime on windows #19409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @vladoovtcharov , Thanks for submitting the PR
CI supported jobs: [unix-gpu, website, sanity, centos-gpu, windows-cpu, centos-cpu, clang, windows-gpu, miscellaneous, unix-cpu, edge] Note: |
lanking520
added
pr-awaiting-testing
|
@mxnet-bot run ci [greeting, centos-cpu] |
|
Jenkins CI successfully triggered : [centos-cpu] |
lanking520
added
pr-awaiting-testing
yajiedesign
approved these changes
Oct 26, 2020
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Feb 19, 2021
Co-authored-by: vlado <vlado@indicalab.com>
szha
pushed a commit
that referenced
this pull request
Feb 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Often it is desirable to use a shared c runtime when build a shared lib on windows. Third party dependencies DMLC and GTEST support this so adding support to mxnet is now easier
Changes
Changed cmake file to not replace 'MD' flags with 'MT' flags if MXNET_FORCE_SHARED_CRT is enabled.
MXNET_FORCE_SHARED_CRT is enabled by default if building a shared lib
Fixed linking for some Debug (which linked to MD instead of MDd)
Added missing RelWithDebinfo and MinSizeRel configurations which were missing in parts.
Comments
Not sure if this should be the default when building a shared lib on windows or just an option?