Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[1.x][submodule] Upgrade to oneDNN v1.7 #19559

Merged
merged 3 commits into from
Nov 19, 2020
Merged

[1.x][submodule] Upgrade to oneDNN v1.7 #19559

merged 3 commits into from
Nov 19, 2020

Conversation

bartekkuncer
Copy link
Contributor

Upgrade oneDNN used on v1.x branch to v1.7.

@mxnet-bot
Copy link

Hey @bartekkuncer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [sanity, centos-cpu, unix-gpu, windows-gpu, edge, miscellaneous, windows-cpu, centos-gpu, clang, website, unix-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 18, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 18, 2020
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci unix-gpu

@mxnet-bot
Copy link

Undefined action detected.
Permissible actions are : run ci [all], run ci [job1, job2]
Example : @mxnet-bot run ci [all]
Example : @mxnet-bot run ci [centos-cpu, clang]

@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 18, 2020
@bartekkuncer
Copy link
Contributor Author

@leezu @szha Please help with the merge. This change only upgrades oneDNN to v1.7.

@TaoLv
Copy link
Member

TaoLv commented Nov 19, 2020

@bartekkuncer Could you please double check the version of oneDNN? I see v1.7 was released on commit oneapi-src/oneDNN@2e47326

https://github.com/oneapi-src/oneDNN/releases/tag/v1.7

@bartekkuncer
Copy link
Contributor Author

@bartekkuncer Could you please double check the version of oneDNN? I see v1.7 was released on commit oneapi-src/oneDNN@2e47326

https://github.com/oneapi-src/oneDNN/releases/tag/v1.7

I checked out branch rls-v1.7. Should I change it to tag v1.7?

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-review PR is waiting for code review labels Nov 19, 2020
@TaoLv
Copy link
Member

TaoLv commented Nov 19, 2020

@bartekkuncer Could you please double check the version of oneDNN? I see v1.7 was released on commit oneapi-src/oneDNN@2e47326
https://github.com/oneapi-src/oneDNN/releases/tag/v1.7

I checked out branch rls-v1.7. Should I change it to tag v1.7?

Yes, please check out the tag of a release. More commits may be checked into the release branch for further patch releases.

@bartekkuncer
Copy link
Contributor Author

@bartekkuncer Could you please double check the version of oneDNN? I see v1.7 was released on commit oneapi-src/oneDNN@2e47326
https://github.com/oneapi-src/oneDNN/releases/tag/v1.7

I checked out branch rls-v1.7. Should I change it to tag v1.7?

Yes, please check out the tag of a release. More commits may be checked into the release branch for further patch releases.

Done.

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 19, 2020
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 19, 2020
@szha szha merged commit db08005 into apache:v1.x Nov 19, 2020
josephevans pushed a commit to josephevans/mxnet that referenced this pull request Dec 8, 2020
@bartekkuncer
[1.x][submodule] Upgrade to oneDNN v1.7 (apache#19559)
52dc702 
* [1.x][submodule] Upgrade to oneDNN v1.7

* Adjust MemFormat test

* Changed mkldnn commit to v1.7 tag
@bartekkuncer bartekkuncer deleted the oneDNN1.71.x branch March 19, 2021 11:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290 anirudh2290 is a code owner

Assignees
No one assigned
Labels
pr-work-in-progress PR is still work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bartekkuncer @mxnet-bot @TaoLv @szha @lanking520