Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Make ONNX export operators work properly with the node input shape #19676

Merged
merged 6 commits into from
Dec 16, 2020
Merged

[v1.x] Make ONNX export operators work properly with the node input shape #19676

merged 6 commits into from
Dec 16, 2020

Conversation

josephevans
Copy link
Contributor

Description

Update the zeros_like and arange_like onnx export operators to properly use correct input node and shape. Updated tests for these 2 operators.

@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, clang, centos-gpu, unix-gpu, windows-gpu, centos-cpu, unix-cpu, website, edge, windows-cpu, sanity]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 15, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Dec 15, 2020
@lanking520 lanking520 added pr-awaiting-response PR is reviewed and waiting for contributor to respond and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 15, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-response PR is reviewed and waiting for contributor to respond labels Dec 15, 2020
Zha0q1
Zha0q1 approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Dec 16, 2020
waytrue17
waytrue17 approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zha0q1 Zha0q1 merged commit 806d91f into apache:v1.x Dec 16, 2020
@josephevans josephevans deleted the onnx_op_updates_v1.x branch December 16, 2020 06:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@waytrue17 waytrue17 waytrue17 approved these changes

@Zha0q1 Zha0q1 Zha0q1 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@josephevans @mxnet-bot @Zha0q1 @waytrue17 @lanking520