This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[v1.x] ONNX support adaptiveAveragePooling2D and update Softmax to support temperature #19736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @waytrue17 , Thanks for submitting the PR
CI supported jobs: [unix-cpu, centos-gpu, sanity, centos-cpu, windows-cpu, miscellaneous, website, clang, edge, windows-gpu, unix-gpu] Note: |
josephevans
reviewed
Jan 8, 2021
waytrue17
changed the title
[WIP] ONNX support adaptiveAveragePooling2D
[v1.x] ONNX support adaptiveAveragePooling2D
Jan 8, 2021
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Jan 8, 2021
@mxnet-bot run ci [unix-cpu] |
Jenkins CI successfully triggered : [unix-cpu] |
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
and removed
pr-work-in-progress
PR is still work in progress
labels
Jan 14, 2021
waytrue17
changed the title
[v1.x] ONNX support adaptiveAveragePooling2D
[v1.x] ONNX support adaptiveAveragePooling2D and update Softmax to support temperature
Jan 14, 2021
lanking520
added
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
labels
Jan 14, 2021
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
pr-awaiting-review
PR is waiting for code review
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Jan 15, 2021
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
and removed
pr-awaiting-review
PR is waiting for code review
labels
Jan 15, 2021
Zha0q1
reviewed
Jan 15, 2021
lanking520
added
pr-awaiting-review
PR is waiting for code review
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Jan 16, 2021
josephevans
approved these changes
Jan 16, 2021
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-awaiting-review
PR is waiting for code review
and removed
pr-awaiting-review
PR is waiting for code review
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Jan 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support onnx conversion of
_contrib_AdaptiveAvgPooling2D
. Update onnx conversion ofsoftmax
to supporttemperature
attribute.Due to some incompatible issue of mx-onnx conversion, currently we only support the conversion when
output_size==1
. Pytorch has the similar implementation: pytorch/pytorch#9711.By inspecting all models in gluon model zoo, 16 of them has
_contrib_AdaptiveAvgPooling2D
. Out of the 16 models, 7 models useoutput_size>1
, which are not supported in this pr.Unsupported models:
psp_resnet50_ade
psp_resnet101_ade
psp_resnet101_voc
psp_resnet101_citys
psp_resnet101_coco
icnet_resnet50_mhpv1
icnet_resnet50_citys
Checklist
Essentials
Changes
Comments