This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[V1.x] ONNX support for Softmax -- optimize for axis=-1 case #19794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this pr we would manually expand MXNet softmax. This was due to the mismatch between the configuration of mxnet and onnx softmax.
However we can adapt the onnx softmax to behave the same as mxnet softmax for the axis==-1 case. This is exactly how Gluon BERT uses softmax. With this optimization we 1) improve the runtime 2) avoid NaN issue caused by Exp when running inference with TensorRT in fp16 mode.