-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[v1.x] Onnx Reshpe support for special caes #19804
Conversation
Hey @Zha0q1 , Thanks for submitting the PR
CI supported jobs: [centos-gpu, sanity, miscellaneous, unix-gpu, edge, windows-cpu, centos-cpu, clang, unix-cpu, website, windows-gpu] Note: |
# In general -2, -3, -4 in the target shape are not supoorted, but there are | ||
# a few special cases that we can convert to supported scenarios | ||
|
||
# If -2 and -4 are not used, then we can just remove the -4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be -2 and -3 are not used
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
In general we do not support -2 -3 -4 in the target shape, but there are some special cases that we can convert to supported cases (only positive values, 0 and -1 in the target shape).
This helps us export a bunch of cv models in the gluon-cv model zoo