Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Onnx export support for ROIAlign #19814

Merged
merged 4 commits into from
Feb 3, 2021
Merged

[v1.x] Onnx export support for ROIAlign #19814

merged 4 commits into from
Feb 3, 2021

Conversation

Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented Feb 1, 2021

No description provided.

@Zha0q1 Zha0q1 requested a review from szha as a code owner February 1, 2021 22:39
@mxnet-bot
Copy link

Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, unix-gpu, miscellaneous, website, centos-cpu, clang, windows-gpu, unix-cpu, edge, centos-gpu, sanity]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Feb 1, 2021
josephevans
josephevans approved these changes Feb 1, 2021
View reviewed changes
python/mxnet/contrib/onnx/mx2onnx/_op_translations.py Outdated
position_sensitive = attrs.get('position_sensitive', 'False')
aligned = attrs.get('aligned', 'False')

'''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these checks be commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized the issue after I created the pr. I have uncommitted them now : )

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 1, 2021
waytrue17
waytrue17 approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 2, 2021
josephevans
josephevans approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 2, 2021
@Zha0q1 Zha0q1 merged commit 6dc8edf into apache:v1.x Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@waytrue17 waytrue17 waytrue17 approved these changes

@josephevans josephevans josephevans approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zha0q1 @mxnet-bot @josephevans @waytrue17 @lanking520