Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Add onnx export function for log2 operator #19822

Merged
merged 2 commits into from
Feb 3, 2021
Merged

[v1.x] Add onnx export function for log2 operator #19822

merged 2 commits into from
Feb 3, 2021

Conversation

josephevans
Copy link
Contributor

Description

Add onnx export operator function for log2 operator. Add unit tests. Update tests to allow comparing NaN values.

Add onnx export function for log2 operator, add operator unit test an…
f80d1ce 
…d update tests to allow comparing NaN values.
@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-cpu, website, centos-gpu, clang, centos-cpu, edge, unix-gpu, windows-gpu, windows-cpu, sanity, miscellaneous]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Feb 2, 2021
Zha0q1
Zha0q1 approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 2, 2021
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 3, 2021
waytrue17
waytrue17 approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Zha0q1 Zha0q1 merged commit 4fbe3d2 into apache:v1.x Feb 3, 2021
@josephevans josephevans deleted the onnx_fixes_round11_v1.x branch February 3, 2021 20:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@waytrue17 waytrue17 waytrue17 approved these changes

@Zha0q1 Zha0q1 Zha0q1 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@josephevans @mxnet-bot @Zha0q1 @waytrue17 @lanking520