Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Backport][PIP] add build target in cmake for osx compat (#19110) #19926

Merged
merged 1 commit into from
Feb 22, 2021
Merged

[Backport][PIP] add build target in cmake for osx compat (#19110) #19926

merged 1 commit into from
Feb 22, 2021

Conversation

access2rohit
Copy link
Contributor

@access2rohit access2rohit commented Feb 19, 2021 •
edited
Loading

Backport #19110 as a part of effort #19911

  • add build target in cmake for osx compat

  • update wheel tags

@mxnet-bot
Copy link

Hey @access2rohit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, unix-gpu, centos-gpu, website, clang, windows-gpu, miscellaneous, sanity, edge, centos-cpu, unix-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Feb 19, 2021
@access2rohit access2rohit mentioned this pull request Feb 19, 2021
Closed
13 tasks
@access2rohit
Copy link
Contributor Author

@szha can you please review

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 19, 2021
@szha
[PIP] add build target in cmake for osx compat (apache#19110)
a746153 
* add build target in cmake for osx compat

* update wheel tags
@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 22, 2021
ChaiBapchya
ChaiBapchya approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ChaiBapchya ChaiBapchya merged commit c97e89c into apache:v1.x Feb 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChaiBapchya ChaiBapchya ChaiBapchya approved these changes

@szha szha szha approved these changes

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@access2rohit @mxnet-bot @szha @ChaiBapchya @lanking520