This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix cd by adding to $PATH #19939
Merged
Fix cd by adding to $PATH #19939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanking520
added
pr-awaiting-testing
josephevans
approved these changes
Feb 22, 2021
lanking520
added
pr-awaiting-testing
lanking520
added
pr-awaiting-testing
Zha0q1
changed the title
lanking520
added
pr-work-in-progress
leezu
reviewed
Feb 23, 2021
| filepath=$(readlink -f wheel_build/dist/*.whl) | ||
| filename=$(basename $filepath) | ||
| variant=$(echo $filename | cut -d'-' -f1 | cut -d'_' -f2 -s) | ||
| if [ -z "${variant}" ]; then | ||
| variant="cpu" | ||
| fi | ||
| export PATH=/usr/local/bin:$PATH |
There was a problem hiding this comment.
Do you mean that /usr/local/bin wasn't on the PATH before? Do you know why it worked at all before?
There was a problem hiding this comment.
We recently changed the ami used by restricted-mxnetlinux-gpu to update the nvidia driver
There was a problem hiding this comment.
Do you think if there is a better place to set PATH?
There was a problem hiding this comment.
It's fine to add it here, I'm just trying to understand the reasoning. Can you explain how it's related to AMI? Wouldn't cd_s3_publish run in a docker container and be independent from the AMI?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19917
This pr tries to fix ^ this issue. Joe helped update g4 instance to use the new nvidia-460 driver, which should be higher than the minimum requirement of the cu112 docker