Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] ONNX Fixes for some NLP models #19973

Merged
merged 4 commits into from
Mar 3, 2021
Merged

[v1.x] ONNX Fixes for some NLP models #19973

merged 4 commits into from
Mar 3, 2021

Conversation

Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented Mar 3, 2021

  1. fix the output missing issue when the output is in the iniatilizer
  2. fix shape issue in zeros_ and ones_
  3. fix one_hot dtype issue
  4. fix scalar_op_helper multi-dimensional tensor not being flattened issue
  5. fix leaky_relu

@Zha0q1 Zha0q1 requested a review from szha as a code owner March 3, 2021 01:54
@mxnet-bot
Copy link

Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [sanity, windows-cpu, unix-cpu, centos-gpu, centos-cpu, windows-gpu, clang, website, unix-gpu, edge, miscellaneous]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 3, 2021
waytrue17
waytrue17 reviewed Mar 3, 2021
View reviewed changes
python/mxnet/contrib/onnx/mx2onnx/_op_translations.py
@@ -822,7 +822,7 @@ def convert_leakyrelu(node, **kwargs):
inputs=input_nodes,
outputs=[name],
name=name)
elif act_type in ('gelu'):
elif act_type in ('gelu',):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we add , here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise this is not a tuple, and elu is in gelu so we will never go into the else branch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use a list for this instead? Why a tuple?

elif act_type in ['gelu']:

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Mar 3, 2021
waytrue17
waytrue17 approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 3, 2021
@Zha0q1 Zha0q1 merged commit 06b5e07 into apache:v1.x Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephevans josephevans josephevans left review comments

@waytrue17 waytrue17 waytrue17 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zha0q1 @mxnet-bot @josephevans @waytrue17 @lanking520