Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.8.x] Update for MXNet 1.8.0 website release #19988

Merged
merged 4 commits into from
Mar 11, 2021
Merged

[v1.8.x] Update for MXNet 1.8.0 website release #19988

merged 4 commits into from
Mar 11, 2021

Conversation

waytrue17
Copy link
Contributor

@waytrue17 waytrue17 commented Mar 5, 2021 •
edited
Loading

Description

Preparing for mxent 1.8 website release. Also dmlc/web-data#265

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @waytrue17 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, clang, windows-cpu, edge, website, sanity, unix-gpu, windows-gpu, centos-cpu, miscellaneous, unix-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Mar 5, 2021
@waytrue17 waytrue17 changed the title [v1.8.x] Update website for 1.8.0 [v1.8.x] Update website release for MXNet 1.8.0 Mar 5, 2021
@waytrue17 waytrue17 changed the title [v1.8.x] Update website release for MXNet 1.8.0 [v1.8.x] Update for MXNet 1.8.0 website release Mar 5, 2021
@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 5, 2021
@szha szha requested a review from ys2843 March 6, 2021 03:50
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-review PR is waiting for code review labels Mar 9, 2021
@waytrue17
Copy link
Contributor Author

@ys2843 @leezu Can you please review? thanks

@access2rohit
Copy link
Contributor

@waytrue17
is there a way to view your changes locally ? If you have tested the website on your local machine can you paste a screenshot ?

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 9, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 9, 2021
@waytrue17
Copy link
Contributor Author

waytrue17 commented Mar 10, 2021 •
edited
Loading

@mxnet-bot run ci [unix-gpu,]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [clang, unix-gpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Mar 10, 2021
@waytrue17
Copy link
Contributor Author

waytrue17 commented Mar 10, 2021 •
edited
Loading

@waytrue17
is there a way to view your changes locally ? If you have tested the website on your local machine can you paste a screenshot ?

Here is a screenshot from the local build, we can see the updated note for gpu pip package
Screen Shot 2021-03-09 at 6 03 26 PM

@lanking520 lanking520 removed the pr-awaiting-testing PR is reviewed and waiting CI build and test label Mar 10, 2021
@lanking520 lanking520 added the pr-work-in-progress PR is still work in progress label Mar 10, 2021
@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 10, 2021
@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 10, 2021
Zha0q1
Zha0q1 approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

access2rohit
access2rohit approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@access2rohit access2rohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Zha0q1 Zha0q1 merged commit eccba71 into apache:v1.8.x Mar 11, 2021
This was referenced Mar 11, 2021
Merged
Merged
mseth10 pushed a commit to mseth10/incubator-mxnet that referenced this pull request Mar 15, 2021
@waytrue17 @mseth10
[v1.8.x] Update for MXNet 1.8.0 website release (apache#19988)
7f24ec8 
* update website for 1.8.0

* add note in gpu_snippet.md

* fix typo

* update header.html

Co-authored-by: Wei Chu <weichu@amazon.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@access2rohit access2rohit access2rohit approved these changes

@Zha0q1 Zha0q1 Zha0q1 approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

@ys2843 ys2843 Awaiting requested review from ys2843

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@waytrue17 @mxnet-bot @access2rohit @Zha0q1 @lanking520