Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] ONNX Type inference support #19990

Merged
merged 6 commits into from
Mar 9, 2021
Merged

Conversation

Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented Mar 6, 2021

Previously we do not have any mechanism for inferring dtypes for intermediate nodes. This is a issue for nodes such as plus_scalar, arange_like etc where we need to make explicitly set the output type based on the input type. Previously we just use a global default value but obviously this is not correct. This pr attempts to introduce proper type inference in the onnx support module

@Zha0q1 Zha0q1 requested a review from szha as a code owner March 6, 2021 01:35
@mxnet-bot
Copy link

Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, miscellaneous, website, sanity, windows-cpu, unix-gpu, centos-cpu, unix-cpu, edge, clang, centos-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Mar 6, 2021
@Zha0q1 Zha0q1 changed the title [v1.x] ONNX Type inference support [wip][v1.x] ONNX Type inference support Mar 6, 2021
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 6, 2021
python/mxnet/contrib/onnx/mx2onnx/export_onnx.py Outdated Show resolved Hide resolved
python/mxnet/contrib/onnx/mx2onnx/export_onnx.py Outdated Show resolved Hide resolved
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Mar 8, 2021
@Zha0q1 Zha0q1 changed the title [wip][v1.x] ONNX Type inference support [v1.x] ONNX Type inference support Mar 8, 2021
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 8, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 8, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 8, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Mar 8, 2021
Copy link
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 9, 2021
@Zha0q1 Zha0q1 merged commit cda1aeb into apache:v1.x Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants