Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Change *MKLDNN* flag names to *ONEDNN* #20071

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Change *MKLDNN* flag names to *ONEDNN* #20071

merged 1 commit into from
Mar 24, 2021

Conversation

bartekkuncer
Copy link
Contributor

@bartekkuncer bartekkuncer commented Mar 22, 2021 •
edited
Loading

Description

Change the remaining MKLDNN flag names to ONEDNN.

Checklist

Changes

  • Change MXNET_MKLDNN_ENABLED
  • Change MXNET_MKLDNN_CACHE_NUM
  • Change MKLDNN_INCLUDE_DIR
  • Change MKLDNN_BUILD_DIR
  • Change MXNET_DISABLE_MKLDNN_FUSE_BN_RELU
  • Change MXNET_DISABLE_MKLDNN_BN_RELU_OPT
  • Change MXNET_DISABLE_MKLDNN_FUSE_CONV_BN
  • Change MXNET_DISABLE_MKLDNN_FUSE_CONV_RELU
  • Change MXNET_DISABLE_MKLDNN_FUSE_CONV_SUM
  • Change MXNET_DISABLE_MKLDNN_CONV_OPT
  • Change MXNET_DISABLE_MKLDNN_QEM_FUSE_ALL
  • Change MXNET_DISABLE_MKLDNN_QEM_FLOAT_OUTPUT
  • Change MXNET_MKLDNN_QFC_DYNAMIC_PARAMS
  • Change MXNET_DISABLE_MKLDNN_FUSE_FC_ELTWISE
  • Change MXNET_DISABLE_MKLDNN_FC_OPT
  • Change ENABLE_MKLDNN_QUANTIZATION_TEST

@mxnet-bot
Copy link

Hey @bartekkuncer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, sanity, centos-gpu, centos-cpu, edge, website, unix-cpu, unix-gpu, windows-cpu, miscellaneous, windows-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 22, 2021
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 22, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-review PR is waiting for code review labels Mar 23, 2021
@bartekkuncer bartekkuncer changed the title Change MXNET_MKLDNN* flag names to MXNET_ONEDNN* Change *MKLDNN* flag names to *ONEDNN* Mar 23, 2021
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 23, 2021
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 23, 2021
@bartekkuncer
Copy link
Contributor Author

@leezu @szha Please help with the merge :)

@szha szha merged commit 50fb3e4 into apache:master Mar 24, 2021
@bartekkuncer bartekkuncer deleted the changeMMCN branch July 14, 2021 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bartekkuncer @mxnet-bot @szha @lanking520