Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Rearrange ONNX tests in Nightly CI #20075

Merged
merged 7 commits into from
Mar 29, 2021
Merged

Conversation

waytrue17
Copy link
Contributor

@waytrue17 waytrue17 commented Mar 22, 2021

Description

Rearrange ONNX tests in Nightly CI to reduce test time and fix timeout issue: https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/NightlyTestsForBinaries/detail/v1.x/14/pipeline/103. Added pytest.ini to document pytest markers

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @waytrue17 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, clang, windows-cpu, sanity, unix-cpu, edge, centos-gpu, website, unix-gpu, windows-gpu, miscellaneous]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-work-in-progress PR is still work in progress label Mar 22, 2021
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@waytrue17 waytrue17 changed the title [WIP][v1.x] Rearrange ONNX tests in Nightly CI [v1.x] Rearrange ONNX tests in Nightly CI Mar 23, 2021
@szha
Copy link
Member

szha commented Mar 23, 2021

I think we can use pytest.ini for documenting the tags. Here's the one we are using on the master branch but I didn't find it in 1.x. https://github.com/apache/incubator-mxnet/blob/master/pytest.ini

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Mar 23, 2021
@waytrue17
Copy link
Contributor Author

I think we can use pytest.ini for documenting the tags. Here's the one we are using on the master branch but I didn't find it in 1.x. https://github.com/apache/incubator-mxnet/blob/master/pytest.ini

Added pytest.ini in v1.x

pytest.ini Show resolved Hide resolved
pytest.ini Outdated Show resolved Hide resolved
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 23, 2021
@waytrue17
Copy link
Contributor Author

waytrue17 commented Mar 23, 2021

@mxnet-bot run ci [unix-cpu, unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [website]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 23, 2021
@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu, unix-gpu, centos-gpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 24, 2021
@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Mar 24, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-review PR is waiting for code review labels Mar 26, 2021
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-merge Review and CI is complete. Ready to Merge labels Mar 26, 2021
@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu, unix-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 29, 2021
@Zha0q1 Zha0q1 merged commit 276f47c into apache:v1.x Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants