Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX][BACKPORT] Impose a plain format on padded concat output #20129

Merged
merged 7 commits into from
Apr 30, 2021
Merged

[BUGFIX][BACKPORT] Impose a plain format on padded concat output #20129

merged 7 commits into from
Apr 30, 2021

Conversation

PawelGlomski-Intel
Copy link
Contributor

Description

Backport of #19735

Right now, oneDNN may choose a blocked format for the output of concat, in cases that may require additional padding (thus more memory). In (de)convolution we make sure to only select a primitive_desc which has the expected (from tensor size) memory size requirements, so the same has to be done in this case.

Unlike convolution's, concat's primitive_desc does not support iteration over multiple implementations, so here I manually impose a plain format when oneDNN would choose a blocked one with padding.

Resolves #19586

@mxnet-bot
Copy link

Hey @PawelGlomski-Intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-cpu, windows-gpu, windows-cpu, website, sanity, centos-cpu, miscellaneous, centos-gpu, clang, unix-gpu, edge]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 6, 2021
@PawelGlomski-Intel
Copy link
Contributor Author

@mxnet-bot run ci [all]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 8, 2021
@PawelGlomski-Intel
Copy link
Contributor Author

@mxnet-bot run ci [windows-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 9, 2021
@PawelGlomski-Intel
Copy link
Contributor Author

@mxnet-bot run ci [windows-cpu]

1 similar comment
@PawelGlomski-Intel
Copy link
Contributor Author

@mxnet-bot run ci [windows-cpu]

@PawelGlomski-Intel
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 removed the pr-work-in-progress PR is still work in progress label Apr 29, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 29, 2021
@PawelGlomski-Intel
Copy link
Contributor Author

PawelGlomski-Intel commented Apr 30, 2021 •
edited
Loading

@szha I believe this can be merged (adding oneDNN support for npx operators won't be included in this PR)

@szha szha merged commit 029947a into apache:master Apr 30, 2021
@szha
Copy link
Member

szha commented Apr 30, 2021

@PawelGlomski-Intel thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha szha left review comments

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MKLDNN error in mx.sym.Concat
5 participants
@PawelGlomski-Intel @mxnet-bot @szha @lanking520 @mseth10