Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] fix mx2onnx wheel #20157

Merged
merged 5 commits into from
Apr 15, 2021
Merged

[v1.x] fix mx2onnx wheel #20157

merged 5 commits into from
Apr 15, 2021

Conversation

Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented Apr 12, 2021

Move the _op_translations_opsetxx files outside the invisible _op_translation folder

@Zha0q1 Zha0q1 requested a review from szha as a code owner April 12, 2021 21:58
@mxnet-bot
Copy link

Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, windows-cpu, unix-cpu, windows-gpu, clang, centos-gpu, sanity, unix-gpu, centos-cpu, website, edge]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 12, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 13, 2021
@waytrue17
Copy link
Contributor

Why would we remove the _op_translation folder? I think having the folder is better for tracking and maintenance, especially when we start to support more and more versions that ONNX will release.

@Zha0q1
Copy link
Contributor Author

Zha0q1 commented Apr 14, 2021

Why would we remove the _op_translation folder? I think having the folder is better for tracking and maintenance, especially when we start to support more and more versions that ONNX will release.

The folder is invisible to setup.py. Let me see how I can keep the folder while still be able to pack the wheel correctly, I am guessing it's because the underscore?

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 14, 2021
@waytrue17
Copy link
Contributor

Why would we remove the _op_translation folder? I think having the folder is better for tracking and maintenance, especially when we start to support more and more versions that ONNX will release.

The folder is invisible to setup.py. Let me see how I can keep the folder while still be able to pack the wheel correctly, I am guessing it's because the underscore?

Yeah, maybe we can try changing the folder name

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 14, 2021
@lanking520 lanking520 removed the pr-work-in-progress PR is still work in progress label Apr 14, 2021
@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Apr 14, 2021
Copy link
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Apr 14, 2021
@Zha0q1 Zha0q1 merged commit 37faacd into apache:v1.x Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants