-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
Hey @samskalicky , Thanks for submitting the PR
CI supported jobs: [unix-gpu, centos-cpu, windows-cpu, unix-cpu, centos-gpu, edge, miscellaneous, website, clang, windows-gpu, sanity] Note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* initial commit * fixed handling * fixed formatting Co-authored-by: Ubuntu <ubuntu@ip-172-31-6-220.us-west-2.compute.internal>
Description
Reuse the params in
cached_op_args
for subsequent calls tooptimize_for
. Currently, if a new param is added during one call tooptimize_for
it is not available for subsequent calls. For example, if you run multiple graph passes then you would need to export/import to get the param. This PR checks ifcached_op_args
is set and reuses those, otherwise it just callscollect_params
like normal.Also added a check for
backend
argument inoptimize_for
and cleaned up logic to callhybridize
now that we're using aclear
argument to control clearing the cached_graph (whereas before we werent calling hybridize in order to not clear the cached_graph).FYI @Kh4L
Checklist
Essentials
Changes
Comments