This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[BUGFIX] fix numpy op fallback bug when ndarray in kwargs #20233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi there,
This PR fixes the issue #20232
When a operator is not implemented in MXNet, it will be fallbacked to official numpy operator.
However, it triggers a bug when the NDArray only exist in
kwargs
.Reproduce Example:
The reason is that the function
_as_onp_array
inmultiarray.py#L380
could not discriminate the NDArray inkwargs
.Checklist
Essentials
Changes
_as_onp_array
inmultiarray.py#L380
support NDArray inkwargs
.