Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Add aarch64 support #20252

Merged
merged 4 commits into from
May 12, 2021
Merged

[v1.x] Add aarch64 support #20252

merged 4 commits into from
May 12, 2021

Conversation

mseth10
Copy link
Contributor

@mseth10 mseth10 commented May 6, 2021

Description

Adds AArch64 build support in MXNet with a native-compilation toolchain. Adds the following files:

  • ci/docker/Dockerfile.publish.ubuntu1804_aarch64_cpu - CD dockerfile used while building MXNet
  • ci/docker/install/ubuntu_aarch64_publish.sh - Installs build dependencies used by above dockerfile
  • config/distribution/linux_aarch64_cpu.cmake - config file defining MXNet build flags
  • tools/* - update build scripts for aarch64 support

Comments

  • Dockerfile and build scripts have been tested locally

@mxnet-bot
Copy link

Hey @mseth10 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, sanity, clang, unix-cpu, unix-gpu, centos-gpu, windows-gpu, windows-cpu, centos-cpu, website, edge]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-work-in-progress PR is still work in progress label May 6, 2021
@mseth10 mseth10 mentioned this pull request May 6, 2021
Open
Zha0q1 and others added 2 commits May 11, 2021 17:06
@Zha0q1
add options to build mkldnn w/ apl and acl
cd369a5 
add options to build mkldnn w/ arm performance libraries and arm compute library
@mseth10
remove libquadmath due to licensing issues apache#19053
b446fd8
@mseth10 mseth10 changed the title [WIP] Add aarch64 support [v1.x] Add aarch64 support May 12, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 12, 2021
Zha0q1
Zha0q1 approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

josephevans
josephevans approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mseth10 mseth10 merged commit 389748a into apache:v1.x May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leezu leezu leezu left review comments

@Zha0q1 Zha0q1 Zha0q1 approved these changes

@josephevans josephevans josephevans approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mseth10 @mxnet-bot @leezu @josephevans @Zha0q1