Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[operator] Add logsigmoid activation function #20268

Merged
merged 4 commits into from
May 21, 2021
Merged

[operator] Add logsigmoid activation function #20268

merged 4 commits into from
May 21, 2021

Conversation

bartekkuncer
Copy link
Contributor

@bartekkuncer bartekkuncer commented May 13, 2021 •
edited
Loading

Description

Add new activation function log sigmoid, available in recently upgraded version of oneDNN, to mxnet.

Checklist

Changes

  • Add native implementation
  • Integrate oneDNN implementation

@mxnet-bot
Copy link

Hey @bartekkuncer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-cpu, windows-gpu, edge, windows-cpu, clang, miscellaneous, sanity, centos-cpu, unix-gpu, website, centos-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 13, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 14, 2021
@bartekkuncer bartekkuncer marked this pull request as draft May 14, 2021 09:32
@bartekkuncer bartekkuncer force-pushed the logsigmoid branch 2 times, most recently from 85902f7 to c117e83 Compare May 19, 2021 14:57
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [website]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [website]

@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [website, windows-cpu, windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [website, windows-cpu, windows-gpu]

@bartekkuncer bartekkuncer force-pushed the logsigmoid branch 3 times, most recently from 8a5a209 to 8b3651f Compare May 20, 2021 09:33
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [website, centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [website, centos-gpu]

@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu, centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu, centos-gpu]

bgawrych
bgawrych suggested changes May 21, 2021
View reviewed changes
src/operator/tensor/elemwise_unary_op_basic.cc Outdated Show resolved Hide resolved
src/operator/nn/mkldnn/mkldnn_act.cc Show resolved Hide resolved
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [windows-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-cpu]

@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [windows-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-cpu]

@bartekkuncer bartekkuncer marked this pull request as ready for review May 21, 2021 15:15
@szha szha merged commit 9308174 into apache:master May 21, 2021
@szha
Copy link
Member

szha commented May 21, 2021

Merged. Thanks for the change @bartekkuncer

@bartekkuncer bartekkuncer deleted the logsigmoid branch May 24, 2021 12:35
Adnios added a commit to Adnios/incubator-mxnet that referenced this pull request Jun 1, 2021
@Adnios
Revert "[operator] Add logsigmoid activation function (apache#20268)"
e99787c 
This reverts commit 9308174.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bgawrych bgawrych bgawrych approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-work-in-progress PR is still work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bartekkuncer @mxnet-bot @szha @bgawrych @mseth10