Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] Fix quantized_op + requantize + dequantize fuse #20323

Merged
merged 6 commits into from
Jun 28, 2021

Conversation

bgawrych
Copy link
Contributor

@bgawrych bgawrych commented Jun 1, 2021

Description

Fix for fusing requantize and dequantize into quantized op when it's outputs have different data types:

                 /---> Quantizable op
 Input ---> FC -|
                 \---> Non quantizable op

image

Found while quantizing google_electra models

Also this PR fixes invalid layer name requested for calibration - occurs when input to quantize node is variable

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

@mxnet-bot
Copy link

Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, miscellaneous, windows-cpu, sanity, clang, edge, unix-cpu, windows-gpu, centos-cpu, website, centos-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jun 1, 2021
Fix for elemwise_mul and FC
Fix passing calibration layers required
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Jun 9, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jun 9, 2021
@bgawrych
Copy link
Contributor Author

@mxnet-bot run ci [centos-cpu, clang, windows-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-cpu, centos-cpu, clang]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 10, 2021
@mseth10 mseth10 removed the pr-work-in-progress PR is still work in progress label Jun 10, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 10, 2021
Copy link
Contributor

@bartekkuncer bartekkuncer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgawrych
Copy link
Contributor Author

@akarbown Can we merge this?

@akarbown akarbown merged commit 835e250 into apache:master Jun 28, 2021
@akarbown
Copy link
Contributor

@akarbown Can we merge this?

@bgawrych Merged. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants