Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[operator] add threshold for mish #20339

Merged
merged 7 commits into from
Jun 15, 2021
Merged

[operator] add threshold for mish #20339

merged 7 commits into from
Jun 15, 2021

Conversation

Adnios
Copy link
Contributor

@Adnios Adnios commented Jun 10, 2021 •
edited
Loading

Description

Add threshold for mish activation. See the comments in #20320

Please help review @ptrendx

@mxnet-bot
Copy link

Hey @Adnios , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, windows-cpu, miscellaneous, windows-gpu, unix-cpu, centos-gpu, centos-cpu, sanity, edge, clang, unix-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-work-in-progress PR is still work in progress label Jun 10, 2021
@Adnios
add threshold for mish
fe63505 
Signed-off-by: Adnios <2780199647@qq.com>
@Adnios
sanity
801e28d 
Signed-off-by: Adnios <2780199647@qq.com>
@Adnios
fix op::softrelu error
03bd329
@Adnios Adnios changed the title [WIP] add threshold for mish [operator] add threshold for mish Jun 11, 2021
@Adnios Adnios marked this pull request as ready for review June 11, 2021 06:14
@Adnios
Copy link
Contributor Author

Adnios commented Jun 11, 2021

@mxnet-bot run ci [windows-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 11, 2021
@Adnios
use op::softrelu
ada6272 
Signed-off-by: Adnios <2780199647@qq.com>
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 12, 2021
@Adnios
try to fix error "op::softrelu and op::tanh"
12bc0aa 
Signed-off-by: Adnios <2780199647@qq.com>
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 12, 2021
@mseth10 mseth10 removed the pr-work-in-progress PR is still work in progress label Jun 12, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 12, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 15, 2021
@Adnios
Copy link
Contributor Author

Adnios commented Jun 15, 2021

@mxnet-bot run ci [unix-cpu, centos-gpu, unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu, unix-cpu, centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 15, 2021
@ptrendx ptrendx merged commit 4f7f62c into apache:master Jun 15, 2021
@ptrendx
Copy link
Member

ptrendx commented Jun 15, 2021

Thanks @Adnios for your contribution :-)!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ptrendx ptrendx ptrendx approved these changes

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Adnios @mxnet-bot @ptrendx @mseth10