Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[2.0] Tweak the argument order for softmax #20413

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented Jul 2, 2021

length is also an input so changing

@set_module('mxnet.numpy_extension')
def softmax(data, axis=-1, length=None, temperature=None, use_length=False, dtype=None):

to

@set_module('mxnet.numpy_extension')
def softmax(data, length=None, axis=-1, temperature=None, use_length=False, dtype=None):

@Zha0q1 Zha0q1 requested a review from szha as a code owner July 2, 2021 01:19
@mxnet-bot
Copy link

Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, centos-gpu, windows-gpu, clang, edge, windows-cpu, sanity, miscellaneous, unix-cpu, centos-cpu, unix-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 2, 2021
Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking backwards incompatible change. Since, master is still beta, this should be okay; But, please capture this in upcoming release notes.

@Zha0q1
Copy link
Contributor Author

Zha0q1 commented Jul 2, 2021

This is a breaking backwards incompatible change. Since, master is still beta, this should be okay; But, please capture this in upcoming release notes.

Yeah, I have sync'ed with @barry-jin who's tracking these changes ;)

@Zha0q1 Zha0q1 merged commit 0716dc0 into apache:master Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants