Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] Fix Precision #20421

Merged
merged 4 commits into from
Jul 8, 2021
Merged

[BUGFIX] Fix Precision #20421

merged 4 commits into from
Jul 8, 2021

Conversation

barry-jin
Copy link
Contributor

Description

fix #20420

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, website, edge, unix-gpu, windows-gpu, windows-cpu, centos-gpu, centos-cpu, clang, sanity, unix-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@barry-jin barry-jin mentioned this pull request Jul 7, 2021
Closed
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 7, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 7, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 7, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Jul 7, 2021
Zha0q1
Zha0q1 approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the quick fix!

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jul 7, 2021
@barry-jin
Copy link
Contributor Author

@mxnet-bot run ci [miscellaneous, unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [miscellaneous, unix-gpu]

@mseth10 mseth10 removed the pr-work-in-progress PR is still work in progress label Jul 7, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jul 7, 2021
@Zha0q1
Copy link
Contributor

Zha0q1 commented Jul 7, 2021 •
edited
Loading

looks like some sources used in unix-gpu and miscellaneous are still syncing

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 8, 2021
@barry-jin
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 8, 2021
@Zha0q1 Zha0q1 merged commit 4e3a4c9 into apache:master Jul 8, 2021
chinakook pushed a commit to chinakook/mxnet that referenced this pull request Aug 4, 2021
@barry-jin @chinakook
[BUGFIX] Fix Precision (apache#20421)
4016bea 
* fix precision

* fix

* fix

* fix
@barry-jin barry-jin deleted the fix-20420 branch August 4, 2021 21:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Zha0q1 Zha0q1 Zha0q1 approved these changes

@leezu leezu leezu approved these changes

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.0] Precission loss when exporting a model from 2.0
5 participants
@barry-jin @mxnet-bot @Zha0q1 @leezu @mseth10