Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v2.0][DOC] Add migration guide #20473

Merged
merged 14 commits into from
Sep 9, 2021
Merged

[v2.0][DOC] Add migration guide #20473

merged 14 commits into from
Sep 9, 2021

Conversation

barry-jin
Copy link
Contributor

@barry-jin barry-jin commented Jul 29, 2021 •
edited
Loading

Description

Add Migration Guide.
Can preview here

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, windows-gpu, edge, centos-gpu, unix-cpu, website, sanity, miscellaneous, centos-cpu, windows-cpu, clang]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 29, 2021
@barry-jin
Copy link
Contributor Author

@mxnet-bot run ci [website, unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [website, unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 30, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 13, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 13, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 16, 2021
@mseth10 mseth10 removed the pr-work-in-progress PR is still work in progress label Aug 16, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 18, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 18, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 18, 2021
@barry-jin
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 19, 2021
szha
szha reviewed Aug 23, 2021
View reviewed changes
Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Overall the content looks good to me. Some grammatical nitpicks:

docs/python_docs/python/tutorials/getting-started/gluon_migration_guide.md Outdated Show resolved Hide resolved
docs/python_docs/python/tutorials/getting-started/gluon_migration_guide.md Outdated Show resolved Hide resolved
docs/python_docs/python/tutorials/getting-started/gluon_migration_guide.md Outdated Show resolved Hide resolved
docs/python_docs/python/tutorials/getting-started/gluon_migration_guide.md Outdated Show resolved Hide resolved
docs/python_docs/python/tutorials/getting-started/gluon_migration_guide.md Outdated Show resolved Hide resolved
docs/python_docs/python/tutorials/getting-started/gluon_migration_guide.md Outdated Show resolved Hide resolved
docs/python_docs/python/tutorials/getting-started/gluon_migration_guide.md Outdated Show resolved Hide resolved
docs/python_docs/python/tutorials/getting-started/gluon_migration_guide.md Outdated Show resolved Hide resolved
docs/python_docs/python/tutorials/getting-started/gluon_migration_guide.md Outdated Show resolved Hide resolved
docs/python_docs/python/tutorials/getting-started/gluon_migration_guide.md Outdated Show resolved Hide resolved
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-review PR is waiting for code review labels Aug 23, 2021
@barry-jin
Copy link
Contributor Author

@szha Thanks for the suggestions! I have updated the migration guide.

@mseth10 mseth10 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 24, 2021
szha
szha approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks!

@barry-jin barry-jin merged commit cb83c4c into apache:master Sep 9, 2021
@barry-jin barry-jin deleted the migration-guide branch September 9, 2021 21:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha szha approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@leezu leezu Awaiting requested review from leezu

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@barry-jin @mxnet-bot @szha @mseth10