This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[BUGFIX] Fix accuracy issue due to reuse of primitives for MKLDNN-AArch64. Fixes #20265. #20482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @cfRod , Thanks for submitting the PR
CI supported jobs: [miscellaneous, website, sanity, windows-cpu, unix-cpu, centos-gpu, unix-gpu, clang, centos-cpu, windows-gpu, edge] Note: |
mseth10
added
the
pr-awaiting-testing
PR is reviewed and waiting CI build and test
label
Aug 3, 2021
cfRod
changed the title
[BUGFIX] Fix reuse of primitives for MKLDNN-AArch64. Fixes #20265.
[BUGFIX] Fix accuracy issue due to reuse of primitives for MKLDNN-AArch64. Fixes #20265.
Aug 3, 2021
mseth10
added
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
labels
Aug 3, 2021
Hi, I will be away until 20th August. Any issues with this PR I will address when I am back. Thanks. |
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-awaiting-review
PR is waiting for code review
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Aug 5, 2021
mseth10
reviewed
Aug 9, 2021
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-awaiting-review
PR is waiting for code review
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Sep 6, 2021
Hi, |
This fix is a workaround for the accuracy issue observed when MXNet is built with Compute Library (ACL). This change includes: * Updating MXNet's AddSign function to generate unique hashes for MKLDNN-ACL backend. * Adding DNNL_AARCH64_USE_ACL to CMakeLists.txt * Adding Crefeda Rodrigues to the contributors list Signed-off-by: cfRod <crefeda.rodrigues@arm.com>
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-awaiting-review
PR is waiting for code review
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Sep 7, 2021
@cfRod thanks for the workaround! |
josephevans
pushed a commit
to josephevans/mxnet
that referenced
this pull request
Feb 28, 2022
…. (apache#20482) This fix is a workaround for the accuracy issue observed when MXNet is built with Compute Library (ACL). This change includes: * Updating MXNet's AddSign function to generate unique hashes for MKLDNN-ACL backend. * Adding DNNL_AARCH64_USE_ACL to CMakeLists.txt * Adding Crefeda Rodrigues to the contributors list Signed-off-by: cfRod <crefeda.rodrigues@arm.com>
josephevans
added a commit
that referenced
this pull request
Mar 1, 2022
…20482) (#20921) This fix is a workaround for the accuracy issue observed when MXNet is built with Compute Library (ACL). This change includes: * Updating MXNet's AddSign function to generate unique hashes for MKLDNN-ACL backend. * Adding DNNL_AARCH64_USE_ACL to CMakeLists.txt * Adding Crefeda Rodrigues to the contributors list Signed-off-by: cfRod <crefeda.rodrigues@arm.com> Co-authored-by: Crefeda Rodrigues <65665931+cfRod@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix is a workaround for the accuracy issue in the grouped convolution unit test observed when MXNet is built with Compute Library for Arm Architecture (ACL).
Fixes #20265
This change includes:
Checklist
Essentials
Changes
Comments