This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[FEATURE] Add feature of retain_grad #20500
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @KexinFeng , Thanks for submitting the PR
CI supported jobs: [centos-gpu, centos-cpu, windows-cpu, unix-gpu, website, sanity, edge, miscellaneous, unix-cpu, windows-gpu, clang] Note: |
mseth10
added
the
pr-awaiting-testing
PR is reviewed and waiting CI build and test
label
Aug 9, 2021
KexinFeng
changed the title
Add feature of retain_grad
Add feature of retain_grad [FEATURE] [issue](https://github.com/apache/incubator-mxnet/issues/11865)
Aug 9, 2021
KexinFeng
changed the title
Add feature of retain_grad [FEATURE] [issue](https://github.com/apache/incubator-mxnet/issues/11865)
Add feature of retain_grad [FEATURE]
Aug 9, 2021
KexinFeng
changed the title
Add feature of retain_grad [FEATURE]
[FEATURE] Add feature of retain_grad
Aug 9, 2021
mseth10
added
pr-work-in-progress
PR is still work in progress
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Aug 9, 2021
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Aug 11, 2021
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
and removed
pr-work-in-progress
PR is still work in progress
labels
Aug 11, 2021
mseth10
added
pr-work-in-progress
PR is still work in progress
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Aug 11, 2021
Jenkins CI successfully triggered : [unix-cpu] |
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-awaiting-review
PR is waiting for code review
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Aug 28, 2021
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-awaiting-review
PR is waiting for code review
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Sep 17, 2021
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Sep 17, 2021
@mxnet-bot run ci [unix-gpu, centos-gpu] |
Jenkins CI successfully triggered : [centos-gpu, unix-gpu] |
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Sep 17, 2021
@mxnet-bot run ci [centos-gpu] |
Jenkins CI successfully triggered : [centos-gpu] |
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-awaiting-review
PR is waiting for code review
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Sep 20, 2021
This was referenced Jul 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR adds the support for fetching the gradients of intermediate variables in a computation graph.
The motivation of this feature comes from this issue.
Checklist
Essentials
Changes
Imperative::MarkVariables
insrc/imperative/imperative.cc
to include the case of marking nonleaf nodesImperative::Backward
insrc/imperative/imperative.cc
to retrieve nonleaf nodes and linknode->info.out_grads[]
to buffered arrays.Graph BuildGradientGraph
to map forward node to the corresponding gradient node entry.Comments
z.retain_grad()
. 2. when it is used combined with detaching computation.u.retain_grad()
is called outside the scope of ag.record(). Otherwise,u.retain_grad()
would be recorded as operation and trigger building of computational node. This is conceptually not desired.