Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[master] [LICENSE] modify erfinv implementation based on scipy (backport #20517) #20550

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

mseth10
Copy link
Contributor

@mseth10 mseth10 commented Aug 23, 2021

Backporting #20517 to master

* modify erfinv implementation based on scipy

* fix lint

* fix lint

* fix host/device gpu error

* fix flag
@mxnet-bot
Copy link

Hey @mseth10 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, unix-gpu, unix-cpu, centos-cpu, windows-gpu, sanity, miscellaneous, edge, centos-gpu, clang, website]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Aug 23, 2021
@mseth10 mseth10 changed the title [master] modify erfinv implementation based on scipy (backport #20517) [master] [LICENSE] modify erfinv implementation based on scipy (backport #20517) Aug 23, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 23, 2021
@mseth10
Copy link
Contributor Author

mseth10 commented Aug 24, 2021

@mxnet-bot run ci [unix-gpu, website]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [website, unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 24, 2021
Copy link
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mseth10 mseth10 merged commit da38e28 into apache:master Aug 25, 2021
@mseth10 mseth10 deleted the fix_license_master branch August 25, 2021 18:23
KexinFeng pushed a commit to KexinFeng/incubator-mxnet that referenced this pull request Aug 27, 2021
…pache#20550)

* modify erfinv implementation based on scipy

* fix lint

* fix lint

* fix host/device gpu error

* fix flag
bgawrych pushed a commit to bgawrych/incubator-mxnet that referenced this pull request Aug 31, 2021
…pache#20550)

* modify erfinv implementation based on scipy

* fix lint

* fix lint

* fix host/device gpu error

* fix flag
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants