Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x][BUGFIX] Export attributes of transformer operators #20555

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

PawelGlomski-Intel
Copy link
Contributor

@PawelGlomski-Intel PawelGlomski-Intel commented Aug 25, 2021

Description

sg_mkldnn_selfatt_qk and sg_mkldnn_selfatt_valatt ops, when not quantized, are not exporting their attributes to the *-symbol.json file, thus making the SymbolBlock.imports/model.load_checkpoint functions crash with an error: "mxnet.base.MXNetError: MXNetError: Required parameter heads of int is not presented, in operator sg_mkldnn_selfatt_*(name="sg_mkldnn_selfatt_*")" when trying to load a model that uses them.

This change fixes this issue.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Assign attributes of transformer operators

@mxnet-bot
Copy link

Hey @PawelGlomski-Intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, windows-cpu, edge, unix-cpu, sanity, centos-gpu, unix-gpu, windows-gpu, website, miscellaneous, clang]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Aug 25, 2021
@PawelGlomski-Intel
Copy link
Contributor Author

@bgawrych Can you please review this?

@mseth10 mseth10 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 25, 2021
@PawelGlomski-Intel
Copy link
Contributor Author

@akarbown I believe this can be merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants