This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[2.0] Split np_elemwise_broadcast_logic_op.cc #20580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mseth10
added
pr-awaiting-testing
mseth10
added
pr-awaiting-testing
mseth10
added
pr-awaiting-testing
mseth10
added
pr-awaiting-testing
mseth10
added
pr-awaiting-testing
|
@mxnet-bot run ci [unix-gpu, website] |
|
Jenkins CI successfully triggered : [website, unix-gpu] |
mseth10
added
pr-awaiting-testing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With more data types introduced in #20478, MXNet is vulnerable to out of memory errors in building process. The website building pipeline and some development have been blocked by this issue a lot:
https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/restricted-website-build-master/activity
As suggested in #19688, this PR will adopt option2 in the proposed solution and split:
np_elemwise_broadcast_logic_op.cc into 8 separate files.
np_elemwise_broadcast_op.cc into 5 separate files.