This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[FEATURE] Add oneDNN support for numpy concatenate operator #20652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @agrabows , Thanks for submitting the PR
CI supported jobs: [clang, edge, centos-gpu, unix-gpu, unix-cpu, sanity, miscellaneous, windows-gpu, centos-cpu, website, windows-cpu] Note: |
mseth10
added
pr-awaiting-testing
bartekkuncer
reviewed
Oct 8, 2021
mseth10
added
pr-awaiting-testing
agrabows
force-pushed
the
master_1dnn_concat
branch
from
2102099
to
964df6a
Compare
mseth10
added
pr-awaiting-testing
agrabows
force-pushed
the
master_1dnn_concat
branch
from
964df6a
to
2c8d63b
Compare
mseth10
added
pr-awaiting-testing
|
@mxnet-bot run ci [unix-cpu] |
|
Jenkins CI successfully triggered : [unix-cpu] |
mseth10
added
pr-awaiting-testing
agrabows
force-pushed
the
master_1dnn_concat
branch
from
ab1e7a6
to
f36c352
Compare
mseth10
added
pr-awaiting-testing
|
@mxnet-bot run ci [unix-cpu] |
|
Jenkins CI successfully triggered : [unix-cpu] |
|
@mxnet-bot run ci [unix-gpu] |
|
Jenkins CI successfully triggered : [unix-gpu] |
mseth10
added
pr-awaiting-testing
|
@mxnet-bot run ci [unix-gpu] |
|
Jenkins CI successfully triggered : [unix-gpu] |
mseth10
added
pr-awaiting-testing
|
@szha Could you please take a look and possibly merge this PR? |
szha
approved these changes
Oct 30, 2021
|
@agrabows thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Function concatenate() from module mxnet.numpy will now be executed by oneDNN primitives as it is done in module mxnet.ndarray. Additionally concat from mxnet.ndarray will gain numpy fuctionality which is flattening input arrays when parameter dim=None.
Checklist
Essentials
Changes
Comments
It was possible to merge both ndarray and numpy concatenate operators into one NNVM_REGISTER_OP, additional functionality was added to ndarray concatenate by this process.
Performance tests from mxnet profiler with 10 warmup runs and 50 test runs of this operator are given below:
Numpy concatenate was about 9 times faster in those tests