Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] Optimize preparation of self attention operators #20682

Merged
merged 1 commit into from
Nov 4, 2021
Merged

[BUGFIX] Optimize preparation of self attention operators #20682

merged 1 commit into from
Nov 4, 2021

Conversation

bgawrych
Copy link
Contributor

Description

This PR fixes problem with redundant double reorder which occurs when dealing with DNNLData

@mxnet-bot
Copy link

Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, clang, website, sanity, centos-cpu, unix-gpu, centos-gpu, unix-cpu, edge, windows-gpu, miscellaneous]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 20, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 26, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 28, 2021
@szha
Copy link
Member

szha commented Oct 30, 2021

Is there a test that covers the modified code path?

@bgawrych
Copy link
Contributor Author

bgawrych commented Nov 3, 2021

Is there a test that covers the modified code path?

@szha There is a test for these operators https://github.com/apache/incubator-mxnet/blob/75e4d1d3e41cc5aef9a0141e40127a75e02ccd04/tests/python/dnnl/subgraphs/test_matmul_subgraph.py#L33

These change only removes redundant data reorder

@szha szha merged commit 9266a91 into apache:master Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bgawrych @mxnet-bot @szha @mseth10