Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[master] Implemented oneDNN Backward Adaptive Pooling kernel #20825

Merged
merged 38 commits into from
Mar 1, 2022
Merged

[master] Implemented oneDNN Backward Adaptive Pooling kernel #20825

merged 38 commits into from
Mar 1, 2022

Conversation

piotrwolinski-intel
Copy link
Contributor

Description

This PR introduces oneDNN backward adaptive pooling implementation.

@piotrwolinski-intel
feat: started working on integrating adaptive pooling merge to master
30886fe
@piotrwolinski-intel
feat: added onednn adaptive pooling to master
c3e8e68
@piotrwolinski-intel
fix: changed SupportDNNLPooling condition to SupportDNNL in adaptive_…
ce8f001 
…avg_pooling.cc
@piotrwolinski-intel
clang fix
54bc2a0
@piotrwolinski-intel
changed typo in comment
8f96f32
@piotrwolinski-intel
finished adaptive backward pooling on master
0df5a32
@piotrwolinski-intel
Been working on solving issue with backward adaptive pooling
daaa9d3
@piotrwolinski-intel
Unified oneDNN pooling implementation calls
d4da970
@piotrwolinski-intel
Added include for vector
3ef827a
@piotrwolinski-intel
feat: added onednn adaptive pooling to master
f16638a
@piotrwolinski-intel
fix: changed SupportDNNLPooling condition to SupportDNNL in adaptive_…
c4e173f 
…avg_pooling.cc
@piotrwolinski-intel
finished adaptive backward pooling on master
debb768
@piotrwolinski-intel
Been working on solving issue with backward adaptive pooling
724ee52
@piotrwolinski-intel
Further working on implementing backward propagation to adaptive pooling
5e176d5
@piotrwolinski-intel
MXNetError: could not execute a primitive dnnl_pooling-inl.h:248
e2508c9
@piotrwolinski-intel
Finished adaptive pooling backward kernel. Only need to remove debug …
30c52b5 
…lines and tweak BackwardAdaptivePoolingStorageType
@piotrwolinski-intel
Changed 2 template functions for standard ones. Added is_adaptive_poo…
8954371 
…ling field to PoolingParam and added parsing to PoolingParamParser.
@piotrwolinski-intel
Tests tweaks
1329bf6
@piotrwolinski-intel
Removed unnecessary comments
8b95412
@piotrwolinski-intel
Added clang style. Changed unnecessary param field for a member funct…
f5f0e01 
…ion. Removed unnecessary check for nullptr.
@piotrwolinski-intel
Removed ceil and floor functions that were used on the integer values
2aed1a8
@piotrwolinski-intel
Added more shapes to test
689fbda
@piotrwolinski-intel
Working on adaptive backward pooling test
177bfc8
@piotrwolinski-intel
Changed SupportDNNLAveragePooling function so that calculations are n…
a8bfea1 
…ow operating on float
@piotrwolinski-intel
Added convolution before pooling in test_adaptive_pooling in test_dnn…
592a158 
…l.py
@piotrwolinski-intel
Added whitespaces in test_adaptive_pooling
099cba3
@piotrwolinski-intel
Modified SupportDNNLAveragePooling and UseAdaptivePaddingKernel to op…
20dffdd 
…erate on integers
@piotrwolinski-intel
Added num_filter as a parameter in test_adaptive_pooling
401934a
@piotrwolinski-intel
Finished test_adaptive_pooling with added convolution before pooling
5a2ee58
@piotrwolinski-intel
Added formatting
ecc2a6f
@mseth10 mseth10 added the pr-awaiting-review PR is waiting for code review label Jan 25, 2022
@piotrwolinski-intel piotrwolinski-intel mentioned this pull request Jan 27, 2022
Merged
bartekkuncer
bartekkuncer approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@bartekkuncer bartekkuncer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

bgawrych
bgawrych suggested changes Feb 14, 2022
View reviewed changes
src/operator/contrib/adaptive_avg_pooling.cc Outdated Show resolved Hide resolved
src/operator/contrib/adaptive_avg_pooling.cc Outdated Show resolved Hide resolved
src/operator/contrib/adaptive_avg_pooling.cc Outdated Show resolved Hide resolved
src/operator/nn/pooling.cc Outdated Show resolved Hide resolved
src/operator/contrib/adaptive_avg_pooling.cc Outdated Show resolved Hide resolved
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 15, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Feb 15, 2022
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 15, 2022
@piotrwolinski-intel
Copy link
Contributor Author

@mxnet-bot run ci [centos-cpu, centos-gpu, windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu, windows-gpu, centos-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 17, 2022
@bgawrych bgawrych merged commit 188d7b6 into apache:master Mar 1, 2022
@piotrwolinski-intel piotrwolinski-intel mentioned this pull request Mar 17, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mozga-intel mozga-intel mozga-intel approved these changes

@bgawrych bgawrych bgawrych approved these changes

@bartekkuncer bartekkuncer bartekkuncer approved these changes

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@piotrwolinski-intel @mxnet-bot @mozga-intel @bgawrych @bartekkuncer @mseth10