This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Make convolution operator fully work with oneDNN v2.4+ #20847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @bartekkuncer , Thanks for submitting the PR
CI supported jobs: [windows-gpu, windows-cpu, centos-cpu, website, centos-gpu, edge, unix-gpu, sanity, unix-cpu, miscellaneous, clang] Note: |
mseth10
added
pr-awaiting-testing
bartekkuncer
force-pushed
the
restoreConvFullFunctionality
branch
from
8067872
to
3aa4649
Compare
mseth10
added
pr-awaiting-testing
mseth10
added
pr-work-in-progress
|
@mxnet-bot run ci [centos-gpu, unix-cpu] |
|
Jenkins CI successfully triggered : [unix-cpu, centos-gpu] |
mseth10
added
pr-awaiting-testing
bgawrych
reviewed
Jan 26, 2022
Co-authored-by: bgawrych <bartlomiej.gawrych@intel.com>
mseth10
added
pr-work-in-progress
|
@mxnet-bot run ci [centos-gpu] |
|
Jenkins CI successfully triggered : [centos-gpu] |
mseth10
added
pr-awaiting-testing
bgawrych
approved these changes
Feb 1, 2022
This was referenced Mar 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the upgrade of oneDNN to version 2.4+ tests/python/dnnl/subgraphs/test_conv_subgraph.py::test_pos_conv_add[True-data_shape1] started failing. During investigation of the problem it turned out that it regards only cases with amount of input channels lower than 4 and switching away from primitive with weight dnnl::format_tag ABcd4b16a4b fixes the issue. This change implements the switch in MXNet and restores the original shape in the failing test (adjusted here: #20662).
This is only temporary solution until the full fix arrives.
Problem tracking issue: #20826.
Checklist
Changes