This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Add oneDNN support for "where" operator #20862
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @bgawrych , Thanks for submitting the PR
CI supported jobs: [miscellaneous, clang, windows-gpu, centos-gpu, unix-gpu, sanity, windows-cpu, centos-cpu, edge, website, unix-cpu] Note: |
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
labels
Jan 31, 2022
bartekkuncer
reviewed
Feb 1, 2022
mseth10
added
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
labels
Feb 1, 2022
bgawrych
force-pushed
the
onednn_where
branch
from
February 7, 2022 07:01
9676351
to
bc06950
Compare
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Feb 7, 2022
bgawrych
force-pushed
the
onednn_where
branch
2 times, most recently
from
February 9, 2022 07:16
fa5fb86
to
9a28cf7
Compare
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Feb 9, 2022
@mxnet-bot run ci [windows-gpu, centos-gpu] |
Jenkins CI successfully triggered : [windows-gpu, centos-gpu] |
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Mar 1, 2022
@mxnet-bot run ci [unix-cpu, centos-gpu] |
1 similar comment
@mxnet-bot run ci [unix-cpu, centos-gpu] |
Jenkins CI successfully triggered : [unix-cpu, centos-gpu] |
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
and removed
pr-work-in-progress
PR is still work in progress
labels
Mar 2, 2022
mozga-intel
approved these changes
Mar 2, 2022
bartekkuncer
approved these changes
Mar 2, 2022
bartekkuncer
reviewed
Mar 2, 2022
mseth10
added
pr-awaiting-review
PR is waiting for code review
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Mar 2, 2022
bgawrych
commented
Mar 3, 2022
Co-authored-by: bartekkuncer <bartosz.kuncer@intel.com>
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-awaiting-review
PR is waiting for code review
and removed
pr-awaiting-review
PR is waiting for code review
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Mar 3, 2022
DominikaJedynak
approved these changes
Mar 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of where operator utilizing few oneDNN primitives.
Implementation creates two masks:
In the next step these mask are applied for left operand (condition met) and for right operand (condition not met). In the end there is sum of both masked input giving proper result.
Performance:
Script:
command:
OMP_NUM_THREADS=32 GOMP_CPU_AFFINITY="0-31:1" python script.py
Benchmarked on AWS c6i.16xlarge