Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix data-apis links #20879

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Fix data-apis links #20879

merged 1 commit into from
Feb 9, 2022

Conversation

bgawrych
Copy link
Contributor

@bgawrych bgawrych commented Feb 7, 2022

No description provided.

@bgawrych bgawrych requested a review from szha as a code owner February 7, 2022 11:18
@mxnet-bot
Copy link

Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-cpu, windows-cpu, sanity, website, centos-gpu, unix-gpu, edge, clang, windows-gpu, miscellaneous, centos-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 7, 2022
@DickJC123
Copy link
Contributor

Not surprisingly, this is affecting all PRs. Hoping for a quick merge since this PR appears to have corrected the linkcheck failure.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 8, 2022
@bgawrych
Copy link
Contributor Author

bgawrych commented Feb 8, 2022

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 8, 2022
@bgawrych
Copy link
Contributor Author

bgawrych commented Feb 8, 2022

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Feb 8, 2022
DickJC123
DickJC123 approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@DickJC123 DickJC123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is a non-functional change to the documentation, and appears to correct the CI failure it targets, I approve this PR.

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 8, 2022
@DickJC123
Copy link
Contributor

Hope you don't mind- triggered the windows-gpu job again hoping for a clean CI (I'd like to see this merged to help the link check failures across all PRs).

@mseth10 mseth10 added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 9, 2022
@bgawrych bgawrych merged commit e7cee79 into apache:master Feb 9, 2022
@bgawrych
Copy link
Contributor Author

bgawrych commented Feb 9, 2022

Merged

@DickJC123 DickJC123 mentioned this pull request Feb 10, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DickJC123 DickJC123 DickJC123 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bgawrych @mxnet-bot @DickJC123 @mseth10