Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

CI fixes #20903

Merged
merged 1 commit into from
Feb 24, 2022
Merged

CI fixes #20903

merged 1 commit into from
Feb 24, 2022

Conversation

RafLit
Copy link
Contributor

@RafLit RafLit commented Feb 21, 2022

Description

The CI is failing due to Jinja version being unsupported:
https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Fwebsite/detail/PR-20899/1/pipeline/
Pinned the new version of the package to fix the issue.

Related issue:
pallets/jinja#1585

@mxnet-bot
Copy link

Hey @RafLit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, website, unix-cpu, windows-cpu, centos-cpu, centos-gpu, miscellaneous, unix-gpu, sanity, clang, edge]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 21, 2022
@RafLit
Copy link
Contributor Author

RafLit commented Feb 21, 2022

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 21, 2022
@RafLit
Copy link
Contributor Author

RafLit commented Feb 21, 2022

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Feb 21, 2022
@DickJC123
Copy link
Contributor

I ran into this issue in my own PR #20876. If you decide you don't want to upgrade Jinja2, I found that adding this requirement:

MarkupSafe==2.0.1

also solves the issue.

@DickJC123 DickJC123 mentioned this pull request Feb 22, 2022
Merged
6 tasks
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 22, 2022
@bgawrych
Copy link
Contributor

Can you also remove broken reference to https://ts.gluon.ai/ in docs/python_docs/python/tutorials/getting-started/crash-course/7-use-gpus.md ?
Jinja upgrade/MarkupSafe freeze and removing this link are both needed to unblock CI

@DickJC123
Copy link
Contributor

I see that this upgrade of Jinja2 from 2.11.3 to 3.0.3 indeed solves the import error. But, since the upgrade is in theory a breaking change, is there a way to confirm that Jinja2 continues to work as needed for MXNet?

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Feb 22, 2022
@RafLit
Copy link
Contributor Author

RafLit commented Feb 22, 2022

I see that this upgrade of Jinja2 from 2.11.3 to 3.0.3 indeed solves the import error. But, since the upgrade is in theory a breaking change, is there a way to confirm that Jinja2 continues to work as needed for MXNet?

You're right - this might need further verification. Adding the MarkupSafe dependency isn't a clean solution either as we don't depend directly on it - Jinja does. So I would see it as a temporary solution to fix the CI problems while we switch to a supported version of Jinja.
@szha I would appreciate your opinion on this problem.

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 23, 2022
@DickJC123 DickJC123 self-requested a review February 23, 2022 05:51
@RafLit RafLit changed the title Jinja upgrade CI fixes Feb 23, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 23, 2022
@RafLit
Copy link
Contributor Author

RafLit commented Feb 23, 2022

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 23, 2022
@RafLit
Copy link
Contributor Author

RafLit commented Feb 23, 2022

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Feb 23, 2022
@RafLit
Copy link
Contributor Author

RafLit commented Feb 23, 2022

please restart linkcheck

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 23, 2022
DickJC123
DickJC123 approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@DickJC123 DickJC123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This upgrade of Jinja2 from 2.11.3 to 3.0.3 is the simplest fix of the import error affecting the website job. If we learn that the docs are adversely affected, we can try a different fix, like leaving Jinja2 at 2.11.3 and adding a pinned MarkupSafe to 2.0.1. So in summary, LGTM.

@mseth10 mseth10 added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 24, 2022
@DickJC123 DickJC123 merged commit 9f47730 into apache:master Feb 24, 2022
@RafLit RafLit mentioned this pull request Feb 24, 2022
Closed
josephevans added a commit to josephevans/mxnet that referenced this pull request Feb 25, 2022
@josephevans
Update Jinja2 (port apache#20903 from master.)
e0c5e03
josephevans added a commit to josephevans/mxnet that referenced this pull request Feb 25, 2022
@josephevans
Port apache#20903 from master.
6fd4f66
RafLit added a commit to RafLit/incubator-mxnet that referenced this pull request Feb 28, 2022
@RafLit
Port apache#20903 from master
3819f22
josephevans added a commit that referenced this pull request Feb 28, 2022
@josephevans
Port #20903 from master. (#20918)
d2bde8a
josephevans added a commit to josephevans/mxnet that referenced this pull request Feb 28, 2022
@josephevans
Port apache#20903 from master. (apache#20918)
1f53193
josephevans added a commit that referenced this pull request Feb 28, 2022
@josephevans
Port #20903 from master. (#20918) (#20920)
ac4439d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DickJC123 DickJC123 DickJC123 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RafLit @mxnet-bot @DickJC123 @bgawrych @mseth10