This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[BUG] fix SymbolBlock constructor from user-defined graph #21044
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where SymbolBlock does not copy user-given parameter attributes such as
lr_mult
. Simple reproducer:Checklist
Essentials
Changes
wd_mult
lr_mult
init
attributes from symbol.stype
attributeComments
stype
attribute is still not copied. There's noMXSymbolInferStorageType
C API. I think a complete fix would require some C API mods.