Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

BUGFIX: Remove type onp.bool. #21213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abdullahselek
Copy link

I have to built mxnet locally on my M1 machine and then installed. But when I import the lib it threw AttributeError error with message module 'numpy' has no attribute 'bool'. This PR is a fix for the deprecation issue.

Description

Remove type onp.bool as np.bool was a deprecated alias for the builtin bool with numpy version 1.20.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • [] All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @abdullahselek , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, centos-cpu, windows-gpu, website, windows-cpu, unix-cpu, unix-gpu, sanity, miscellaneous, edge, centos-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Aug 21, 2023
- `np.bool` was a deprecated alias for the builtin `bool` with version 1.20.
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Aug 21, 2023
@abdullahselek
Copy link
Author

abdullahselek commented Sep 13, 2023

@mxnet-bot run ci [all]

@mxnet-bot
Copy link

Undefined action detected.
Permissible actions are : run ci [all], run ci [job1, job2]
Example : @mxnet-bot run ci [all]
Example : @mxnet-bot run ci [centos-cpu, clang]

1 similar comment
@mxnet-bot
Copy link

Undefined action detected.
Permissible actions are : run ci [all], run ci [job1, job2]
Example : @mxnet-bot run ci [all]
Example : @mxnet-bot run ci [centos-cpu, clang]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [website, windows-gpu, centos-gpu, sanity, windows-cpu, miscellaneous, clang, unix-gpu, unix-cpu, centos-cpu, edge]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-work-in-progress PR is still work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants