This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Enable DTypes in deconvolution #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
|
could you add a type consistency check in tests/python/gpu/test_operator_gpu.py? |
|
otherwise lgtm |
vchuravy
force-pushed
the
vc/dtype_deconv
branch
2 times, most recently
from
120260e
to
4f48838
Compare
|
done. |
|
rebased and ready to merge. |
|
Need to rebase again... |
|
Yes it indeed is. It especially slows you down if you are in a different timezone, than the majority of people with merge rights. |
|
@piiswrong rebased |
|
@tqchen good for merging after test finishes |
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #2302