Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Delete workspace before build. #8195

Merged
merged 2 commits into from
Oct 10, 2017
Merged

Delete workspace before build. #8195

merged 2 commits into from
Oct 10, 2017

Conversation

goswamig
Copy link
Contributor

Description

Delete workspace before build.

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • For user-facing API changes, API doc string has been updated.
  • To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Intersting edge cases to note here

@goswamig
Copy link
Contributor Author

@indhub @piiswrong

@indhub
Copy link
Contributor

indhub commented Oct 10, 2017

Build are currently breaking and this PR is supposed to fix that. Without this change, this change itself cannot be built by the build machines. So, I'm merging this change in. I'll monitor the builds to make sure this change does no harm.

Jenkinsfile Outdated
@@ -30,6 +31,7 @@ def init_git() {

def init_git_win() {
retry(5) {
deleteDir()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gautamkmr, This should be outside the retry in both the cases

@indhub indhub merged commit 573a010 into apache:master Oct 10, 2017
mbaijal pushed a commit to mbaijal/incubator-mxnet that referenced this pull request Oct 12, 2017
* Delete workspace before build.

* Move 'deleteDir' outside the retry.
indhub pushed a commit that referenced this pull request Oct 13, 2017
* Delete workspace before build. (#8195)

* Delete workspace before build.

* Move 'deleteDir' outside the retry.

* Jenkins: fix Jenkinsfile indentation

* add Julia package as a submodule and enable CPU build
crazy-cat pushed a commit to crazy-cat/incubator-mxnet that referenced this pull request Oct 26, 2017
* Delete workspace before build.

* Move 'deleteDir' outside the retry.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants